Does it have the sock holders

yes, it has Velcro sock holders

Does your junk stay in place when you wear these? Also, what is so good about the cup? Is bio flex more comfortable?

I once pinched a nut, but I have very meaty clankers.

For a 33 inch waist would medium adult medium or large give me a snug fit?

Hi, Thanks for checking out an item we offer within our Amazon store. The Shock Doctor hockey shorts run a bit small so with a 33" waist we would recommend the large size for a good fit. Let us know if you have any other questions. Thanks again. Larry, LNC Sports, LLC

Are these model #362 shorts?

Hello, Yes, these will be the same design as the 362. The model variation largely is dependent on the cup pairing and the variation of the cup style its paired with. These will be the Hockey compression shorts you are accustomed to with the flaps to attach hockey socks as needed! If you have additional questions please contact our customer service department via email - amazon@unitedspb.com or by phone at (800)-233-6956 and we will gladly assist you!